This repository was archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6e7368
to
5cdd9ea
Compare
gkalpak
added a commit
to gkalpak/angular-seed
that referenced
this pull request
Apr 12, 2016
….conf.js`) This brings the config files on par with the tutorial (see angular/angular-phonecat#326). Related to angular#329.
This was referenced Apr 12, 2016
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Apr 12, 2016
Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Apr 12, 2016
Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Apr 12, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
This was referenced Apr 12, 2016
gkalpak
added a commit
to gkalpak/angular-phonecat
that referenced
this pull request
Apr 12, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#289. Mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular.js#14416. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#198 Fixes angular#214 Fixes angular#224 Fixes angular#230 Fixes angular#243 Fixes angular#246 Fixes angular#252 Fixes angular#277 Fixes angular#286 Fixes angular#295 Fixes angular#303 Fixes angular#304 Fixes angular#323 Fixes angular#324 Closes angular#268 Closes angular#270 Closes angular#278 Closes angular#280 Closes angular#289 Closes angular#309 Closes angular#311 Closes angular#319
gkalpak
added a commit
to gkalpak/angular-seed
that referenced
this pull request
Apr 12, 2016
…rotractor) This brings the config files on par with the tutorial (see angular/angular-phonecat#326). It also updates Node used on Travis to version 4.4 and switches to Chrome for testing. Related to angular#329.
gkalpak
added a commit
to gkalpak/angular-seed
that referenced
this pull request
Apr 12, 2016
…rotractor) This brings the config files on par with the tutorial (see angular/angular-phonecat#326). It also updates the version of Node used on Travis to `4.4`. Related to angular#329.
Fixes angular#212 Fixes angular#245 Fixes angular#259 Closes angular#308
5cdd9ea
to
2cfc1c7
Compare
Superceeded by #341. |
gkalpak
added a commit
to angular/angular-phonecat
that referenced
this pull request
May 24, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) #289. Mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular.js#14416. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes #198 Fixes #214 Fixes #224 Fixes #230 Fixes #243 Fixes #246 Fixes #252 Fixes #277 Fixes #286 Fixes #295 Fixes #303 Fixes #304 Fixes #323 Fixes #324 Closes #268 Closes #270 Closes #278 Closes #280 Closes #289 Closes #309 Closes #311 Closes #319
gkalpak
added a commit
to angular/angular-phonecat
that referenced
this pull request
May 24, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) #289. Mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular.js#14416. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes #198 Fixes #214 Fixes #224 Fixes #230 Fixes #243 Fixes #246 Fixes #252 Fixes #277 Fixes #286 Fixes #295 Fixes #303 Fixes #304 Fixes #323 Fixes #324 Closes #268 Closes #270 Closes #278 Closes #280 Closes #289 Closes #309 Closes #311 Closes #319
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
May 24, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated both
bower
andnpm
dependencies to latest versions. Most notablyangular
,karma
,protractor
andhttp-server
. Note that some older versions ofhttp-server
(and transitivelykarma
) threw errors on Windows with non-english locales.Tested all scripts with node versions
4.4.0
and5.9.0
(on Windows 10) and everything seems to work as expected.There is also a 2nd (optional) commit that changes the served folder to
./app
(instead of the project root). I think it makes sense, but I may have missed the reasoning for the original decision.